From cff27e9f40cdfe8f49692c64e5963553a7353743 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 18 Jul 2008 11:02:18 +0000 Subject: [PATCH] enable format-safety checks for virDomainReportError * src/domain_conf.c (virDomainReportError): Declare using ATTRIBUTE_FORMAT(printf, 3, 4). * Makefile.maint (msg_gen_function): Add virDomainReportError. --- ChangeLog | 11 +++++++++-- Makefile.maint | 1 + src/domain_conf.c | 4 ++++ 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index a19085e727..f0d29fd12d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,13 @@ +Wed Jul 18 13:01:38 CEST 2008 Jim Meyering + + enable format-safety checks for virDomainReportError + * src/domain_conf.c (virDomainReportError): Declare using + ATTRIBUTE_FORMAT(printf, 3, 4). + * Makefile.maint (msg_gen_function): Add virDomainReportError. + Thu Jul 17 17:18:24 CEST 2008 Daniel Veillard - * src/storage_backend_fs.c: patch from Cole Robinson fixing + * src/storage_backend_fs.c: patch from Cole Robinson fixing pool-create for netfs format 'auto' Thu Jul 17 13:47:56 CEST 2008 Daniel Veillard @@ -10,7 +17,7 @@ Thu Jul 17 13:47:56 CEST 2008 Daniel Veillard Wed Jul 16 22:36:43 CEST 2008 Daniel Veillard - * src/libvirt.c src/openvz_driver.c: fix the description of the ID + * src/libvirt.c src/openvz_driver.c: fix the description of the ID domain lookup and fix the OpenVZ routine Wed Jul 16 17:25:02 CEST 2008 Daniel Veillard diff --git a/Makefile.maint b/Makefile.maint index 5da2984dee..03800f8905 100644 --- a/Makefile.maint +++ b/Makefile.maint @@ -352,6 +352,7 @@ msg_gen_function += ReportError msg_gen_function += qemudReportError msg_gen_function += openvzLog msg_gen_function += openvzError +msg_gen_function += virDomainReportError # Uncomment the following and run "make syntax-check" to see diagnostics # that are not yet marked for translation, but that need to be rewritten diff --git a/src/domain_conf.c b/src/domain_conf.c index 82c0ee6aa2..2ff5d1a698 100644 --- a/src/domain_conf.c +++ b/src/domain_conf.c @@ -126,6 +126,10 @@ VIR_ENUM_IMPL(virDomainGraphics, VIR_DOMAIN_GRAPHICS_TYPE_LAST, "vnc") +static void virDomainReportError(virConnectPtr conn, + int code, const char *fmt, ...) + ATTRIBUTE_FORMAT(printf, 3, 4); + static void virDomainReportError(virConnectPtr conn, int code, const char *fmt, ...) { -- GitLab