diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7f1735b6cbfabaec3918c0de65852bbd482d10e4..097796b84b10e4110448614fed80c5ca7c29bb64 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16772,47 +16772,45 @@ virDomainPinFind(virDomainPinDefPtr *def, } int -virDomainVcpuPinAdd(virDomainPinDefPtr **vcpupin_list, - size_t *nvcpupin, - unsigned char *cpumap, - int maplen, - int vcpu) +virDomainPinAdd(virDomainPinDefPtr **pindef_list, + size_t *npin, + unsigned char *cpumap, + int maplen, + int id) { - virDomainPinDefPtr vcpupin = NULL; + virDomainPinDefPtr pindef = NULL; - if (!vcpupin_list) + if (!pindef_list) return -1; - vcpupin = virDomainPinFind(*vcpupin_list, - *nvcpupin, - vcpu); - if (vcpupin) { - vcpupin->id = vcpu; - virBitmapFree(vcpupin->cpumask); - vcpupin->cpumask = virBitmapNewData(cpumap, maplen); - if (!vcpupin->cpumask) + pindef = virDomainPinFind(*pindef_list, *npin, id); + if (pindef) { + pindef->id = id; + virBitmapFree(pindef->cpumask); + pindef->cpumask = virBitmapNewData(cpumap, maplen); + if (!pindef->cpumask) return -1; return 0; } - /* No existing vcpupin matches vcpu, adding a new one */ + /* No existing pindef matches id, adding a new one */ - if (VIR_ALLOC(vcpupin) < 0) + if (VIR_ALLOC(pindef) < 0) goto error; - vcpupin->id = vcpu; - vcpupin->cpumask = virBitmapNewData(cpumap, maplen); - if (!vcpupin->cpumask) + pindef->id = id; + pindef->cpumask = virBitmapNewData(cpumap, maplen); + if (!pindef->cpumask) goto error; - if (VIR_APPEND_ELEMENT(*vcpupin_list, *nvcpupin, vcpupin) < 0) + if (VIR_APPEND_ELEMENT(*pindef_list, *npin, pindef) < 0) goto error; return 0; error: - virDomainPinDefFree(vcpupin); + virDomainPinDefFree(pindef); return -1; } diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 3d8795f02e184e167cc77bd7ba7f40716b8c36df..8f5610a49c4538e7d287c4f4e8728d9a3e88bb70 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2557,11 +2557,11 @@ int virDomainDefCompatibleDevice(virDomainDefPtr def, virDomainDeviceDefPtr dev, virDomainDeviceAction action); -int virDomainVcpuPinAdd(virDomainPinDefPtr **vcpupin_list, - size_t *nvcpupin, - unsigned char *cpumap, - int maplen, - int vcpu); +int virDomainPinAdd(virDomainPinDefPtr **pindef_list, + size_t *npin, + unsigned char *cpumap, + int maplen, + int id); void virDomainVcpuPinDel(virDomainDefPtr def, int vcpu); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7e652291d1b4b939a78bbaf5b39c116715d30e8b..0b50a4e0b3dba9f8d6e52594ce6e2244a5c944da 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -384,6 +384,7 @@ virDomainObjTaint; virDomainParseMemory; virDomainPausedReasonTypeFromString; virDomainPausedReasonTypeToString; +virDomainPinAdd; virDomainPinDefArrayFree; virDomainPinDefCopy; virDomainPinDefFree; @@ -440,7 +441,6 @@ virDomainTPMBackendTypeToString; virDomainTPMDefFree; virDomainTPMModelTypeFromString; virDomainTPMModelTypeToString; -virDomainVcpuPinAdd; virDomainVcpuPinDel; virDomainVideoDefaultRAM; virDomainVideoDefaultType; diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index b471b5bac04b68853210f6062b89d9d370aea827..45dd385f9be584d9884a02a7e410e3bd87350dc1 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -1999,11 +1999,11 @@ libxlDomainPinVcpuFlags(virDomainPtr dom, unsigned int vcpu, goto endjob; targetDef->cputune.nvcpupin = 0; } - if (virDomainVcpuPinAdd(&targetDef->cputune.vcpupin, - &targetDef->cputune.nvcpupin, - cpumap, - maplen, - vcpu) < 0) { + if (virDomainPinAdd(&targetDef->cputune.vcpupin, + &targetDef->cputune.nvcpupin, + cpumap, + maplen, + vcpu) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("failed to update or add vcpupin xml")); goto endjob; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a941bcfee287212b9e05dcc897780b246028acdd..5ec07f41b7d68e2c6408fbef41b893917468d9b1 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5123,8 +5123,8 @@ qemuDomainPinVcpuFlags(virDomainPtr dom, newVcpuPinNum = 0; } - if (virDomainVcpuPinAdd(&newVcpuPin, &newVcpuPinNum, - cpumap, maplen, vcpu) < 0) { + if (virDomainPinAdd(&newVcpuPin, &newVcpuPinNum, + cpumap, maplen, vcpu) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("failed to update vcpupin")); goto endjob; @@ -5188,11 +5188,11 @@ qemuDomainPinVcpuFlags(virDomainPtr dom, goto endjob; persistentDef->cputune.nvcpupin = 0; } - if (virDomainVcpuPinAdd(&persistentDef->cputune.vcpupin, - &persistentDef->cputune.nvcpupin, - cpumap, - maplen, - vcpu) < 0) { + if (virDomainPinAdd(&persistentDef->cputune.vcpupin, + &persistentDef->cputune.nvcpupin, + cpumap, + maplen, + vcpu) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("failed to update or add vcpupin xml of " "a persistent domain")); @@ -5400,7 +5400,7 @@ qemuDomainPinEmulator(virDomainPtr dom, if (VIR_ALLOC(newVcpuPin) < 0) goto endjob; - if (virDomainVcpuPinAdd(&newVcpuPin, &newVcpuPinNum, cpumap, maplen, -1) < 0) { + if (virDomainPinAdd(&newVcpuPin, &newVcpuPinNum, cpumap, maplen, -1) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("failed to update vcpupin")); virDomainPinDefArrayFree(newVcpuPin, newVcpuPinNum); diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 1722c3f0d3bffa4ec8bf2edf7236b5020773dae4..6c8ec7cb50196fb800f399696c99008490266aca 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -1897,11 +1897,11 @@ xenDaemonDomainPinVcpu(virConnectPtr conn, goto cleanup; def->cputune.nvcpupin = 0; } - if (virDomainVcpuPinAdd(&def->cputune.vcpupin, - &def->cputune.nvcpupin, - cpumap, - maplen, - vcpu) < 0) { + if (virDomainPinAdd(&def->cputune.vcpupin, + &def->cputune.nvcpupin, + cpumap, + maplen, + vcpu) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("failed to add vcpupin xml entry")); return -1;