From cab2b44d8bab35a033567835cc6d05396d9ee1d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Tue, 14 Jun 2016 17:13:13 +0200 Subject: [PATCH] check-spacing: use non-capturing groups --- build-aux/check-spacing.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/build-aux/check-spacing.pl b/build-aux/check-spacing.pl index becdbe9332..f4fedbcea4 100755 --- a/build-aux/check-spacing.pl +++ b/build-aux/check-spacing.pl @@ -43,7 +43,7 @@ foreach my $file (@ARGV) { $data =~ s/'[";,=]'/'X'/g; # Kill any quoted strings - $data =~ s,"([^\\\"]|\\.)*","XXX",g; + $data =~ s,"(?:[^\\\"]|\\.)*","XXX",g; # Kill any C++ style comments $data =~ s,//.*$,//,; @@ -91,8 +91,8 @@ foreach my $file (@ARGV) { my $kw = $1; # Allow space after keywords only - if ($kw =~ /^(if|for|while|switch|return)$/) { - $tmpdata =~ s/($kw\s\()/XXX(/; + if ($kw =~ /^(?:if|for|while|switch|return)$/) { + $tmpdata =~ s/(?:$kw\s\()/XXX(/; } else { print "Whitespace after non-keyword:\n"; print "$file:$.: $line"; @@ -102,7 +102,7 @@ foreach my $file (@ARGV) { } # Require whitespace immediately after keywords - if ($data =~ /\b(if|for|while|switch|return)\(/) { + if ($data =~ /\b(?:if|for|while|switch|return)\(/) { print "No whitespace after keyword:\n"; print "$file:$.: $line"; $ret = 1; -- GitLab