From caad0a878337b52c4453444bb227b74cce6e6d5f Mon Sep 17 00:00:00 2001 From: Matthias Bolte Date: Wed, 17 Mar 2010 22:21:03 +0100 Subject: [PATCH] qemu: Fix FD leak in qemudStartVMDaemon The logfile FD is dup2'ed in __virExec in the child. The FD needs to be closed in the parent, otherwise it leaks. --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 67d9aded7c..a3aae33c8b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2975,6 +2975,9 @@ static int qemudStartVMDaemon(virConnectPtr conn, if (virDomainSaveStatus(driver->caps, driver->stateDir, vm) < 0) goto abort; + if (logfile != -1) + close(logfile); + return 0; cleanup: -- GitLab