From c5781e37a092e6222ff286c2835a92abe668bed3 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Wed, 15 Mar 2017 15:09:35 -0400 Subject: [PATCH] test: Don't assume a configFile exists for Storage Pool tests Fix a "bug" in the storage pool test driver code which "assumed" testStoragePoolObjSetDefaults should fill in the configFile for both the Define/Create (persistent) and CreateXML (transient) pools by just VIR_FREE()'ing it during CreateXML. Because the configFile was filled in, during Destroy the pool wouldn't be free'd which could cause issues for future patches which add tests to validate vHBA creation for the storage pool using the same name. --- src/test/test_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 18792bc974..102395637c 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4439,6 +4439,12 @@ testStoragePoolCreateXML(virConnectPtr conn, pool = NULL; goto cleanup; } + + /* *SetDefaults fills this in for the persistent pools, but this + * would be a transient pool so remove it; otherwise, the Destroy + * code will not Remove the pool */ + VIR_FREE(pool->configFile); + pool->active = 1; event = virStoragePoolEventLifecycleNew(pool->def->name, pool->def->uuid, -- GitLab