From c4461ff57b4e327afead3e2f18ceb409dfd81f3c Mon Sep 17 00:00:00 2001
From: "Daniel P. Berrange" <berrange@redhat.com>
Date: Sun, 30 Sep 2007 15:36:47 +0000
Subject: [PATCH] Only use bootloader for paravirt guests

---
 ChangeLog                                     |  6 ++++
 src/xend_internal.c                           | 32 ++++++++++---------
 .../sexpr2xml-no-source-cdrom.xml             |  1 -
 3 files changed, 23 insertions(+), 16 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 7e655622b7..3ce29ce851 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+Sun Sep 30 12:27:36 EST 2007 Daniel P. Berrange <berrange@redhat.com>
+
+	* src/xend_internal.c: Don't include <bootloader/> for HVM guests
+	* tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml: revert previous
+	change since HVM doesn't use bootloaders
+
 Sun Sep 30 15:20:36 CEST 2007 Daniel Veillard <veillard@redhat.com>
 
 	* src/virsh.c: use virNodeGetFreeMemory() for freecell without
diff --git a/src/xend_internal.c b/src/xend_internal.c
index b0e8d0cc90..5b28065df8 100644
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -1401,25 +1401,27 @@ xend_parse_sexp_desc(virConnectPtr conn, struct sexpr *root,
     virUUIDFormat(uuid, uuidstr);
     virBufferVSprintf(&buf, "  <uuid>%s</uuid>\n", uuidstr);
 
-    tmp = sexpr_node(root, "domain/bootloader");
-    if (tmp != NULL) {
-        bootloader = 1;
-        virBufferVSprintf(&buf, "  <bootloader>%s</bootloader>\n", tmp);
-    } else if (sexpr_has(root, "domain/bootloader")) {
-        bootloader = 1;
-        virBufferVSprintf(&buf, "  <bootloader/>\n");
-    }
-    tmp = sexpr_node(root, "domain/bootloader_args");
-    if (tmp != NULL && bootloader) {
-        /*
-         * Only insert bootloader_args if there is also a bootloader param
-         */
-        virBufferEscapeString(&buf, "  <bootloader_args>%s</bootloader_args>\n", tmp);
+    hvm = sexpr_lookup(root, "domain/image/hvm") ? 1 : 0;
+    if (!hvm) {
+        tmp = sexpr_node(root, "domain/bootloader");
+        if (tmp != NULL) {
+            bootloader = 1;
+            virBufferVSprintf(&buf, "  <bootloader>%s</bootloader>\n", tmp);
+        } else if (sexpr_has(root, "domain/bootloader")) {
+            bootloader = 1;
+            virBufferVSprintf(&buf, "  <bootloader/>\n");
+        }
+        tmp = sexpr_node(root, "domain/bootloader_args");
+        if (tmp != NULL && bootloader) {
+            /*
+             * Only insert bootloader_args if there is also a bootloader param
+             */
+            virBufferEscapeString(&buf, "  <bootloader_args>%s</bootloader_args>\n", tmp);
+        }
     }
 
     if (domid != 0) {
         if (sexpr_lookup(root, "domain/image")) {
-            hvm = sexpr_lookup(root, "domain/image/hvm") ? 1 : 0;
             if (xend_parse_sexp_desc_os(conn, root, &buf, hvm, bootloader) < 0)
                 goto error;
         }
diff --git a/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml b/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml
index cfc1949c69..429474aff2 100644
--- a/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml
+++ b/tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml
@@ -1,7 +1,6 @@
 <domain type='xen' id='6'>
   <name>test</name>
   <uuid>cc2315e7-d26a-307a-438c-6d188ec4c09c</uuid>
-  <bootloader/>
   <os>
     <type>hvm</type>
     <loader>/usr/lib/xen/boot/hvmloader</loader>
-- 
GitLab