diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c index 6afd77758b269347559836c0efac3317d9c1dce8..330a391de4151bd2d8a8e738fc3421d4a25e3c8f 100644 --- a/src/qemu/qemu_alias.c +++ b/src/qemu/qemu_alias.c @@ -382,10 +382,19 @@ qemuAssignDeviceRedirdevAlias(virDomainDefPtr def, int -qemuAssignDeviceRNGAlias(virDomainRNGDefPtr rng, - size_t idx) +qemuAssignDeviceRNGAlias(virDomainDefPtr def, + virDomainRNGDefPtr rng) { - if (virAsprintf(&rng->info.alias, "rng%zu", idx) < 0) + size_t i; + int maxidx = 0; + int idx; + + for (i = 0; i < def->nrngs; i++) { + if ((idx = qemuDomainDeviceAliasIndex(&def->rngs[i]->info, "rng")) >= maxidx) + maxidx = idx + 1; + } + + if (virAsprintf(&rng->info.alias, "rng%d", maxidx) < 0) return -1; return 0; @@ -480,7 +489,7 @@ qemuAssignDeviceAliases(virDomainDefPtr def, virQEMUCapsPtr qemuCaps) return -1; } for (i = 0; i < def->nrngs; i++) { - if (qemuAssignDeviceRNGAlias(def->rngs[i], i) < 0) + if (virAsprintf(&def->rngs[i]->info.alias, "rng%zu", i) < 0) return -1; } if (def->tpm) { diff --git a/src/qemu/qemu_alias.h b/src/qemu/qemu_alias.h index 0861acd2d337fde810b8715b71110420cd625841..f09466d77ebf891d1f09925261b2488522c1df40 100644 --- a/src/qemu/qemu_alias.h +++ b/src/qemu/qemu_alias.h @@ -54,8 +54,8 @@ int qemuAssignDeviceRedirdevAlias(virDomainDefPtr def, virDomainRedirdevDefPtr redirdev, int idx); -int qemuAssignDeviceRNGAlias(virDomainRNGDefPtr rng, - size_t idx); +int qemuAssignDeviceRNGAlias(virDomainDefPtr def, + virDomainRNGDefPtr rng); int qemuAssignDeviceAliases(virDomainDefPtr def, virQEMUCapsPtr qemuCaps); diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 9fdf66a84019434c003cc75526b81bbcca3282f9..b9a8b51594633f0b29a2df55e06dd410774d7198 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1625,7 +1625,7 @@ qemuDomainAttachRNGDevice(virQEMUDriverPtr driver, const char *type; int ret = -1; - if (qemuAssignDeviceRNGAlias(rng, vm->def->nrngs) < 0) + if (qemuAssignDeviceRNGAlias(vm->def, rng) < 0) return -1; /* preallocate space for the device definition */