提交 bba36f7f 编写于 作者: M Matthias Bolte

esx: Fix potential memory leak in esxVI_BuildFullTraversalSpecItem

If esxVI_String_DeepCopyValue or esxVI_SelectionSpec_AppendToList fail
then selectionSpec would leak. Add a free call in the failure path to
fix the leak.
上级 055d21d2
...@@ -1163,8 +1163,6 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList, ...@@ -1163,8 +1163,6 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList,
currentSelectSetName = selectSetNames; currentSelectSetName = selectSetNames;
while (currentSelectSetName != NULL && *currentSelectSetName != '\0') { while (currentSelectSetName != NULL && *currentSelectSetName != '\0') {
selectionSpec = NULL;
if (esxVI_SelectionSpec_Alloc(&selectionSpec) < 0 || if (esxVI_SelectionSpec_Alloc(&selectionSpec) < 0 ||
esxVI_String_DeepCopyValue(&selectionSpec->name, esxVI_String_DeepCopyValue(&selectionSpec->name,
currentSelectSetName) < 0 || currentSelectSetName) < 0 ||
...@@ -1173,6 +1171,7 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList, ...@@ -1173,6 +1171,7 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList,
goto failure; goto failure;
} }
selectionSpec = NULL;
currentSelectSetName += strlen(currentSelectSetName) + 1; currentSelectSetName += strlen(currentSelectSetName) + 1;
} }
} }
...@@ -1186,6 +1185,7 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList, ...@@ -1186,6 +1185,7 @@ esxVI_BuildFullTraversalSpecItem(esxVI_SelectionSpec **fullTraversalSpecList,
failure: failure:
esxVI_TraversalSpec_Free(&traversalSpec); esxVI_TraversalSpec_Free(&traversalSpec);
esxVI_SelectionSpec_Free(&selectionSpec);
return -1; return -1;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册