From b907fd75fa826a8285dc33fcf6117c7833e2853b Mon Sep 17 00:00:00 2001 From: Martin Kletzander Date: Wed, 12 Sep 2018 16:32:56 +0200 Subject: [PATCH] qemu: Report less errors on driver startup It is not a problem at all if the `tss` user/group does not exist, the code fallbacks to the `root` user/group. However we report a warning for no reason on every start-up. Fix this by checking if the user/group actually exists. Signed-off-by: Martin Kletzander --- src/qemu/qemu_conf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index a4f545ef92..4d69b599fe 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -197,9 +197,11 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged) if (virAsprintf(&cfg->swtpmStorageDir, "%s/lib/libvirt/swtpm", LOCALSTATEDIR) < 0) goto error; - if (virGetUserID("tss", &cfg->swtpm_user) < 0) + if (virDoesUserExist("tss") != 0 || + virGetUserID("tss", &cfg->swtpm_user) < 0) cfg->swtpm_user = 0; /* fall back to root */ - if (virGetGroupID("tss", &cfg->swtpm_group) < 0) + if (virDoesGroupExist("tss") != 0 || + virGetGroupID("tss", &cfg->swtpm_group) < 0) cfg->swtpm_group = 0; /* fall back to root */ } else { char *rundir; -- GitLab