From b523302c422a4d2c1cefb301d85d9b2c47a8c582 Mon Sep 17 00:00:00 2001 From: Nikolay Shirokovskiy Date: Wed, 24 Feb 2016 11:38:39 +0300 Subject: [PATCH] libxl: Remove extraneous AFFECT_LIVE and not active check. libxlDomainPinVcpuFlags calls virDomainLiveConfigHelperMethod which will call virDomainObjUpdateModificationImpact make the same AFFECT_LIVE flags and !active check, so remove this duplicated check. Signed-off-by: Nikolay Shirokovskiy Signed-off-by: John Ferlan --- src/libxl/libxl_driver.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 29d65cd4c3..6b316db42a 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -2346,12 +2346,6 @@ libxlDomainPinVcpuFlags(virDomainPtr dom, unsigned int vcpu, if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0) goto cleanup; - if ((flags & VIR_DOMAIN_AFFECT_LIVE) && !virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("domain is inactive")); - goto endjob; - } - if (virDomainLiveConfigHelperMethod(cfg->caps, driver->xmlopt, vm, &flags, &targetDef) < 0) goto endjob; -- GitLab