From a923865a0e0e7d8dc1bcd08a0b13a1a7e3cb20a7 Mon Sep 17 00:00:00 2001
From: Jiri Denemark <jdenemar@redhat.com>
Date: Sat, 1 Jun 2013 01:28:36 +0200
Subject: [PATCH] virsh iface-bridge: Ignore delay if stp is turned off

Delay only makes sense with STP enabled.
---
 tools/virsh-interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c
index 1c2e40baf9..2bdb2150e1 100644
--- a/tools/virsh-interface.c
+++ b/tools/virsh-interface.c
@@ -894,7 +894,7 @@ cmdInterfaceBridge(vshControl *ctl, const vshCmd *cmd)
         goto cleanup;
     }
 
-    if ((delay || stp) &&
+    if (stp &&
         ((virAsprintf(&delay_str, "%d", delay) < 0) ||
          !xmlSetProp(br_node, BAD_CAST "delay", BAD_CAST delay_str))) {
         vshError(ctl, _("Failed to set bridge delay %d in xml document"), delay);
-- 
GitLab