From 9b095625e4d983e6ed3b633a170ca5ff95c67c41 Mon Sep 17 00:00:00 2001
From: "Daniel P. Berrange" <berrange@redhat.com>
Date: Tue, 8 Apr 2014 15:43:45 +0100
Subject: [PATCH] Fix leak on OOM in virNWFilterVarValueCreateSimpleCopyValue

If virNWFilterVarValueCreateSimple fails with OOM, then
'val' will be leaked by virNWFilterVarValueCreateSimpleCopyValue

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 src/conf/nwfilter_params.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c
index 40eccc4930..3e85bc1623 100644
--- a/src/conf/nwfilter_params.c
+++ b/src/conf/nwfilter_params.c
@@ -126,10 +126,14 @@ virNWFilterVarValuePtr
 virNWFilterVarValueCreateSimpleCopyValue(const char *value)
 {
     char *val;
+    virNWFilterVarValuePtr ret;
 
     if (VIR_STRDUP(val, value) < 0)
         return NULL;
-    return virNWFilterVarValueCreateSimple(val);
+    ret = virNWFilterVarValueCreateSimple(val);
+    if (!ret)
+        VIR_FREE(val);
+    return ret;
 }
 
 const char *
-- 
GitLab