From 970ac2a0fe19eb6088fb4cd8b982014ee9b143dc Mon Sep 17 00:00:00 2001 From: Martin Kletzander Date: Tue, 19 Aug 2014 14:54:30 +0200 Subject: [PATCH] qemu: forbid negative blkio values Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1131306 Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 801044ba3a..28a56a97fa 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7627,19 +7627,19 @@ qemuDomainParseBlkioDeviceStr(char *blkioDeviceStr, const char *type, temp = p + 1; if (STREQ(type, VIR_DOMAIN_BLKIO_DEVICE_WEIGHT)) { - if (virStrToLong_ui(temp, &p, 10, &result[i].weight) < 0) + if (virStrToLong_uip(temp, &p, 10, &result[i].weight) < 0) goto error; } else if (STREQ(type, VIR_DOMAIN_BLKIO_DEVICE_READ_IOPS)) { - if (virStrToLong_ui(temp, &p, 10, &result[i].riops) < 0) + if (virStrToLong_uip(temp, &p, 10, &result[i].riops) < 0) goto error; } else if (STREQ(type, VIR_DOMAIN_BLKIO_DEVICE_WRITE_IOPS)) { - if (virStrToLong_ui(temp, &p, 10, &result[i].wiops) < 0) + if (virStrToLong_uip(temp, &p, 10, &result[i].wiops) < 0) goto error; } else if (STREQ(type, VIR_DOMAIN_BLKIO_DEVICE_READ_BPS)) { - if (virStrToLong_ull(temp, &p, 10, &result[i].rbps) < 0) + if (virStrToLong_ullp(temp, &p, 10, &result[i].rbps) < 0) goto error; } else if (STREQ(type, VIR_DOMAIN_BLKIO_DEVICE_WRITE_BPS)) { - if (virStrToLong_ull(temp, &p, 10, &result[i].wbps) < 0) + if (virStrToLong_ullp(temp, &p, 10, &result[i].wbps) < 0) goto error; } else { goto error; -- GitLab