From 9369348eb8084548d0b8e9ddb586260d23fddff4 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Fri, 4 May 2018 15:34:41 +0200 Subject: [PATCH] tests: qemucapsprobemock: Fail if JSON reply from qemu can't be reformatted Rather than skipping output on failure fail loudly. Signed-off-by: Peter Krempa Reviewed-by: John Ferlan --- tests/qemucapsprobemock.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/qemucapsprobemock.c b/tests/qemucapsprobemock.c index f26fa6b285..a0d2acb69a 100644 --- a/tests/qemucapsprobemock.c +++ b/tests/qemucapsprobemock.c @@ -86,9 +86,12 @@ qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon, ret = realQemuMonitorJSONIOProcessLine(mon, line, msg); - if (ret == 0 && - (value = virJSONValueFromString(line)) && - (json = virJSONValueToString(value, 1))) { + if (ret == 0) { + if (!(value = virJSONValueFromString(line)) || + !(json = virJSONValueToString(value, true))) { + fprintf(stderr, "Failed to reformat reply string '%s'\n", line); + abort(); + } if (first) { first = false; -- GitLab