From 89ef1589a2a576b2df49296f7d837fa27d420d8f Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Fri, 3 Jun 2016 10:11:59 +0200 Subject: [PATCH] Drop virPerfGetEventFd This function is not used anywhere. Moreover, the code that would use lives in virperf.c and therefore has access to the FD anyway. Well, for instance virPerfReadEvent is doing just that. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 - src/util/virperf.c | 19 ------------------- src/util/virperf.h | 3 --- 3 files changed, 23 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index e325168e53..333bf7c8b2 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2083,7 +2083,6 @@ virPerfEventIsEnabled; virPerfEventTypeFromString; virPerfEventTypeToString; virPerfFree; -virPerfGetEventFd; virPerfNew; virPerfReadEvent; diff --git a/src/util/virperf.c b/src/util/virperf.c index 450b3baf2a..a0997f94b1 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -241,16 +241,6 @@ bool virPerfEventIsEnabled(virPerfPtr perf, return event->enabled; } -int virPerfGetEventFd(virPerfPtr perf, - virPerfEventType type) -{ - virPerfEventPtr event = virPerfGetEvent(perf, type); - if (event == NULL) - return false; - - return event->fd; -} - int virPerfReadEvent(virPerfPtr perf, virPerfEventType type, @@ -299,15 +289,6 @@ virPerfEventIsEnabled(virPerfPtr perf ATTRIBUTE_UNUSED, return false; } -int -virPerfGetEventFd(virPerfPtr perf ATTRIBUTE_UNUSED, - virPerfEventType type ATTRIBUTE_UNUSED) -{ - virReportSystemError(ENXIO, "%s", - _("Perf not supported on this platform")); - return -1; -} - int virPerfReadEvent(virPerfPtr perf ATTRIBUTE_UNUSED, virPerfEventType type ATTRIBUTE_UNUSED, diff --git a/src/util/virperf.h b/src/util/virperf.h index 769e85a2fa..716341019b 100644 --- a/src/util/virperf.h +++ b/src/util/virperf.h @@ -51,9 +51,6 @@ int virPerfEventDisable(virPerfPtr perf, bool virPerfEventIsEnabled(virPerfPtr perf, virPerfEventType type); -int virPerfGetEventFd(virPerfPtr perf, - virPerfEventType type); - int virPerfReadEvent(virPerfPtr perf, virPerfEventType type, uint64_t *value); -- GitLab