From 86139a408dae1f238f9bec6e1eac2f59dc8c00db Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Tue, 24 Sep 2013 16:26:18 +0100 Subject: [PATCH] Fix leak on OOM in qemuBuildCommandLine dealing with sound card The qemuBuildCommandLine code for parsing sound cards will leak an intermediate variable if an OOM occurs. Move the free'ing of the variable earlier to avoid the leak. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_command.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 50b4d70aa8..caabf81d6e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -9102,7 +9102,7 @@ qemuBuildCommandLine(virConnectPtr conn, goto error; virCommandAddArg(cmd, str); - + VIR_FREE(str); if (sound->model == VIR_DOMAIN_SOUND_MODEL_ICH6 || sound->model == VIR_DOMAIN_SOUND_MODEL_ICH9) { char *codecstr = NULL; @@ -9130,8 +9130,6 @@ qemuBuildCommandLine(virConnectPtr conn, VIR_FREE(codecstr); } } - - VIR_FREE(str); } } } else { -- GitLab