From 85ce4d1f7335ed1944070ef3d362a10da6958413 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Thu, 26 Feb 2015 09:03:09 +0100 Subject: [PATCH] conf: error out on missing dhcp host attributes In virNetworkDHCPHostDefParseXML an error is reported when partialOkay == true, and none of ip, mac, name were supplied. Add the missing goto and error out in this case. (cherry picked from commit b15b21f3a52945644c7ccbbe1dd51b86d36ca777) --- src/conf/network_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 81e311e446..f3ec1758a2 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -737,6 +737,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName, "must be specified for static host definition " "in network '%s' "), networkName); + goto cleanup; } } else { /* normal usage - you need at least name (IPv6) or one of MAC -- GitLab