From 81a8fc34ad79386deb774f1e234797ae3641584c Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Thu, 4 Sep 2014 17:18:48 -0400 Subject: [PATCH] qemu: Resolve Coverity NEGATIVE_RETURNS Coverity notes that if the virConnectListAllDomains returns a negative value then the loop at the cleanup label that ends on numDomains will have issues. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 78b8a82607..7ff60ecfe6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1004,9 +1004,11 @@ qemuStateStop(void) ret = -1; cleanup: - for (i = 0; i < numDomains; i++) - virDomainFree(domains[i]); - VIR_FREE(domains); + if (domains) { + for (i = 0; i < numDomains; i++) + virDomainFree(domains[i]); + VIR_FREE(domains); + } VIR_FREE(flags); virObjectUnref(conn); virObjectUnref(cfg); -- GitLab