From 77117e18b703534c43e4e78caf060d7b06653ed8 Mon Sep 17 00:00:00 2001 From: Andrea Bolognani Date: Mon, 4 Dec 2017 16:22:02 +0100 Subject: [PATCH] util: gettid() is Linux-specific The manual page clearly states that gettid() is Linux-specific and should not be used in programs that are intended to be portable. Unfortunately, it looks like macOS implemented the functionality and defined SYS_gettid accordingly, only to deprecate syscall() altogether with 10.12 (Sierra), released last late year. To avoid compilation errors, call gettid() on Linux only. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrange --- src/util/virthread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virthread.c b/src/util/virthread.c index 6c495158f5..05b5572f5f 100644 --- a/src/util/virthread.c +++ b/src/util/virthread.c @@ -268,7 +268,7 @@ bool virThreadIsSelf(virThreadPtr thread) * the pthread_self() id on Linux. */ unsigned long long virThreadSelfID(void) { -#if defined(HAVE_SYS_SYSCALL_H) && defined(SYS_gettid) +#if defined(HAVE_SYS_SYSCALL_H) && defined(SYS_gettid) && defined(__linux__) pid_t tid = syscall(SYS_gettid); return tid; #else -- GitLab