diff --git a/ChangeLog b/ChangeLog
index fd37d8fb95d88e8970833bf94c340d0e78817720..b299e943c08e1048dfe184cc260b45438505d739 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+Thu Nov  8 18:59:39 CET 2007 Daniel Veillard <veillard@redhat.com>
+
+	* src/virsh.c: patch from Jim Meyering to use gcc's printf attribute.
+
 Thu Nov  8 17:06:50 CET 2007 Daniel Veillard <veillard@redhat.com>
 
 	* src/virsh.c: patch from Jim Meyering to correct vshCommandOptInt
diff --git a/src/virsh.c b/src/virsh.c
index 852dea2afb4babb9824929d5290112af3ced5c88..5e0cfb88b4dadfb8b01f7ff2e80c9422954be6bb 100644
--- a/src/virsh.c
+++ b/src/virsh.c
@@ -254,8 +254,10 @@ static virNetworkPtr vshCommandOptNetworkBy(vshControl * ctl, vshCmd * cmd,
     vshCommandOptNetworkBy(_ctl, _cmd, _optname, _name,             \
                            VSH_BYUUID|VSH_BYNAME)
 
-static void vshPrintExtra(vshControl * ctl, const char *format, ...);
-static void vshDebug(vshControl * ctl, int level, const char *format, ...);
+static void vshPrintExtra(vshControl * ctl, const char *format, ...)
+    ATTRIBUTE_FORMAT(printf, 2, 3);
+static void vshDebug(vshControl * ctl, int level, const char *format, ...)
+    ATTRIBUTE_FORMAT(printf, 3, 4);
 
 /* XXX: add batch support */
 #define vshPrint(_ctl, ...)   fprintf(stdout, __VA_ARGS__)