From 6780791f18c6fc786244e187b6c06b24f8cc7545 Mon Sep 17 00:00:00 2001 From: Nitesh Konkar Date: Thu, 23 Feb 2017 20:25:37 +0530 Subject: [PATCH] perf: add alignment_faults software perf event support This patch adds support and documentation for the alignment_faults perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 8 ++++++++ docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-domain.h | 10 ++++++++++ src/libvirt-domain.c | 3 +++ src/qemu/qemu_driver.c | 1 + src/util/virperf.c | 6 +++++- src/util/virperf.h | 1 + tests/genericxml2xmlindata/generic-perf.xml | 1 + tools/virsh.pod | 3 +++ 9 files changed, 33 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 23508e2bff..680b98593f 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1954,6 +1954,7 @@ <event name='cpu_migrations' enabled='no'/> <event name='page_faults_min' enabled='no'/> <event name='page_faults_maj' enabled='no'/> + <event name='alignment_faults' enabled='no'/> </perf> ... @@ -2082,6 +2083,13 @@ applications running on the platform perf.page_faults_maj + + alignment_faults + the count of alignment faults, that is when + the load or store is not aligned properly, by + applications running on the platform + perf.alignment_faults +

Devices

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 82327c6d9f..1f0c729148 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -440,6 +440,7 @@ cpu_migrations page_faults_min page_faults_maj + alignment_faults diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index f6e5c5a760..0c0fb182da 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2260,6 +2260,16 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats); */ # define VIR_PERF_PARAM_PAGE_FAULTS_MAJ "page_faults_maj" +/** + * VIR_PERF_PARAM_ALIGNMENT_FAULTS: + * + * Macro for typed parameter name that represents alignment_faults + * perf event which can be used to measure the count of alignment + * faults by applications running on the platform. It corresponds + * to the "perf.alignment_faults" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_ALIGNMENT_FAULTS "alignment_faults" + int virDomainGetPerfEvents(virDomainPtr dom, virTypedParameterPtr *params, int *nparams, diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index bfca1eacda..012795202f 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11269,6 +11269,9 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * "perf.page_faults_maj" - The count of major page faults as unsigned * long long. It is produced by the * page_faults_maj perf event. + * "perf.alignment_faults" - The count of alignment faults as unsigned + * long long. It is produced by the + * alignment_faults perf event * * Note that entire stats groups or individual stat fields may be missing from * the output in case they are not supported by the given hypervisor, are not diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a2177d3742..a6d8f141b5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9574,6 +9574,7 @@ qemuDomainSetPerfEvents(virDomainPtr dom, VIR_PERF_PARAM_CPU_MIGRATIONS, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_PAGE_FAULTS_MIN, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_PAGE_FAULTS_MAJ, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_ALIGNMENT_FAULTS, VIR_TYPED_PARAM_BOOLEAN, NULL) < 0) return -1; diff --git a/src/util/virperf.c b/src/util/virperf.c index b3dd5c7897..3f015965c2 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -46,7 +46,8 @@ VIR_ENUM_IMPL(virPerfEvent, VIR_PERF_EVENT_LAST, "stalled_cycles_backend", "ref_cpu_cycles", "cpu_clock", "task_clock", "page_faults", "context_switches", "cpu_migrations", - "page_faults_min", "page_faults_maj"); + "page_faults_min", "page_faults_maj", + "alignment_faults"); struct virPerfEvent { int type; @@ -136,6 +137,9 @@ static struct virPerfEventAttr attrs[] = { {.type = VIR_PERF_EVENT_PAGE_FAULTS_MAJ, .attrType = PERF_TYPE_SOFTWARE, .attrConfig = PERF_COUNT_SW_PAGE_FAULTS_MAJ}, + {.type = VIR_PERF_EVENT_ALIGNMENT_FAULTS, + .attrType = PERF_TYPE_SOFTWARE, + .attrConfig = PERF_COUNT_SW_ALIGNMENT_FAULTS}, }; typedef struct virPerfEventAttr *virPerfEventAttrPtr; diff --git a/src/util/virperf.h b/src/util/virperf.h index 49d4ba7c6b..4e464600ce 100644 --- a/src/util/virperf.h +++ b/src/util/virperf.h @@ -54,6 +54,7 @@ typedef enum { VIR_PERF_EVENT_CPU_MIGRATIONS, /* Count of cpu migrations */ VIR_PERF_EVENT_PAGE_FAULTS_MIN, /* Count of minor page faults */ VIR_PERF_EVENT_PAGE_FAULTS_MAJ, /* Count of major page faults */ + VIR_PERF_EVENT_ALIGNMENT_FAULTS, /* Count of alignment faults */ VIR_PERF_EVENT_LAST } virPerfEventType; diff --git a/tests/genericxml2xmlindata/generic-perf.xml b/tests/genericxml2xmlindata/generic-perf.xml index a5b6dfb50d..b48f96c38f 100644 --- a/tests/genericxml2xmlindata/generic-perf.xml +++ b/tests/genericxml2xmlindata/generic-perf.xml @@ -33,6 +33,7 @@ + diff --git a/tools/virsh.pod b/tools/virsh.pod index 3269e9c6b3..0fe4188c99 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -971,6 +971,7 @@ I<--perf> returns the statistics of all enabled perf events: "perf.cpu_migrations" - the count of cpu migrations "perf.page_faults_min" - the count of minor page faults "perf.page_faults_maj" - the count of major page faults + "perf.alignment_faults" - the count of alignment faults See the B command for more details about each event. @@ -2354,6 +2355,8 @@ B by applications running on the platform. page_faults_maj - Provides the count major page faults by applications running on the platform. + alignment_faults - Provides the count alignment faults + by applications running on the platform. B: The statistics can be retrieved using the B command using the I<--perf> flag. -- GitLab