diff --git a/ChangeLog b/ChangeLog
index afabf8f0a8eed4434fd3d0d5eb596f17d6e28e31..f504f0750f8bae9865695e33e150786ca4eaefe7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Wed Sep  3 14:37:06 CEST 2008 Daniel Veillard <veillard@redhat.com>
+
+	* src/virsh.c: patch from Cole Robinson to add output on attach
+	  and detach success
+
 Wed Sep  3 14:23:48 CEST 2008 Daniel Veillard <veillard@redhat.com>
 
 	* AUTHORS: add Cole Robinson as commiter
diff --git a/src/virsh.c b/src/virsh.c
index 1fb07ad8a2be0da4ddb389d052420ee922afd3b3..45ec1bd04b8409a5a98ce0312d5e82dcd4e98819 100644
--- a/src/virsh.c
+++ b/src/virsh.c
@@ -4627,6 +4627,8 @@ cmdAttachDevice(vshControl *ctl, const vshCmd *cmd)
         vshError(ctl, FALSE, _("Failed to attach device from %s"), from);
         virDomainFree(dom);
         return FALSE;
+    } else {
+        vshPrint(ctl, _("Device attached successfully\n"));
     }
 
     virDomainFree(dom);
@@ -4684,6 +4686,8 @@ cmdDetachDevice(vshControl *ctl, const vshCmd *cmd)
         vshError(ctl, FALSE, _("Failed to detach device from %s"), from);
         virDomainFree(dom);
         return FALSE;
+    } else {
+        vshPrint(ctl, _("Device detached successfully\n"));
     }
 
     virDomainFree(dom);
@@ -4792,8 +4796,11 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd)
     if (!buf) goto cleanup;
     strcat(buf, "    </interface>\n");
 
-    if (virDomainAttachDevice(dom, buf))
+    if (virDomainAttachDevice(dom, buf)) {
         goto cleanup;
+    } else {
+        vshPrint(ctl, _("Interface attached successfully\n"));
+    }
 
     ret = TRUE;
 
@@ -4909,8 +4916,10 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd)
     ret = virDomainDetachDevice(dom, (char *)xmlBufferContent(xml_buf));
     if (ret != 0)
         ret = FALSE;
-    else
+    else {
+        vshPrint(ctl, _("Interface detached successfully\n"));
         ret = TRUE;
+    }
 
  cleanup:
     if (dom)
@@ -5076,6 +5085,8 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd)
 
     if (virDomainAttachDevice(dom, buf))
         goto cleanup;
+    else
+        vshPrint(ctl, _("Disk attached successfully\n"));
 
     ret = TRUE;
 
@@ -5183,8 +5194,10 @@ cmdDetachDisk(vshControl *ctl, const vshCmd *cmd)
     ret = virDomainDetachDevice(dom, (char *)xmlBufferContent(xml_buf));
     if (ret != 0)
         ret = FALSE;
-    else
+    else {
+        vshPrint(ctl, _("Disk detached successfully\n"));
         ret = TRUE;
+    }
 
  cleanup:
     xmlXPathFreeObject(obj);