From 528e26e77fd83abd74987cf2662221e9bd728e13 Mon Sep 17 00:00:00 2001
From: Michal Privoznik <mprivozn@redhat.com>
Date: Sat, 20 Apr 2019 07:01:04 +0200
Subject: [PATCH] vmx: Free @firmware in virVMXParseConfig

The @firmware string is allocated, but never freed.

 4 bytes in 1 blocks are definitely lost in loss record 1 of 44
    at 0x483579F: malloc (vg_replace_malloc.c:299)
    by 0x76FB469: strdup (strdup.c:42)
    by 0x497B6DE: virStrdup (virstring.c:966)
    by 0x48F6FD3: virConfGetValueString (virconf.c:908)
    by 0x4B3E9B6: virVMXGetConfigStringHelper (vmx.c:736)
    by 0x4B3EA6B: virVMXGetConfigString (vmx.c:756)
    by 0x4B41AEA: virVMXParseConfig (vmx.c:1832)
    by 0x10B8E4: testCompareFiles (vmx2xmltest.c:79)
    by 0x10BAB8: testCompareHelper (vmx2xmltest.c:124)
    by 0x10D058: virTestRun (testutils.c:174)
    by 0x10CDDA: mymain (vmx2xmltest.c:288)
    by 0x10F11C: virTestMain (testutils.c:1096)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pino Toscano <ptoscano@redhat.com>
---
 src/vmx/vmx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index 35b83a2320..7bb5eb956d 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
@@ -1861,6 +1861,7 @@ virVMXParseConfig(virVMXContext *ctx,
     VIR_FREE(sched_cpu_shares);
     VIR_FREE(guestOS);
     virCPUDefFree(cpu);
+    VIR_FREE(firmware);
 
     return def;
 }
-- 
GitLab