From 500d77f1811c371598ab7a5fcc90bad45b52bafd Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Tue, 10 Mar 2015 18:33:59 -0400 Subject: [PATCH] xenapi: Resolve Coverity FORWARD_NULL Since inception. Coverity complains that the code checks "(record == NULL && !session->ok)", but doesn't check (record != NULL) before dereferencing at "record->is_a_template" --- src/xenapi/xenapi_driver.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index afb6d6c8d8..821e9d94ce 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -1646,9 +1646,11 @@ xenapiConnectNumOfDefinedDomains(virConnectPtr conn) xen_vm_set_free(result); return -1; } - if (record->is_a_template == 0) - DomNum++; - xen_vm_record_free(record); + if (record) { + if (record->is_a_template == 0) + DomNum++; + xen_vm_record_free(record); + } } xen_vm_set_free(result); return DomNum; -- GitLab