From 464ad16f5ca9b286e7f9e4288e81b7e8245cf083 Mon Sep 17 00:00:00 2001 From: Satoru Moriya Date: Mon, 4 Mar 2013 17:27:45 +0000 Subject: [PATCH] qemu: fix wrong evaluation in qemuDomainSetMemoryParameters 19c6ad9a (qemu: Refactor qemuDomainSetMemoryParameters) introduced a new macro, VIR_GET_LIMIT_PARAMETER(PARAM, VALUE). But if statement in the macro is not correct and so set_XXXX flags are set to false in the wrong. As a result, libvirt ignores all memtune parameters. This patch fixes the conditional expression to work correctly. Signed-off-by: Satoru Moriya --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7048ce9c28..42b8c77b21 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7280,7 +7280,7 @@ qemuDomainSetMemoryParameters(virDomainPtr dom, } #define VIR_GET_LIMIT_PARAMETER(PARAM, VALUE) \ - if ((rc = virTypedParamsGetULLong(params, nparams, PARAM, &VALUE) < 0)) \ + if ((rc = virTypedParamsGetULLong(params, nparams, PARAM, &VALUE)) < 0) \ goto cleanup; \ \ if (rc == 1) \ -- GitLab