From 4313e1b9b12adcfda6972eab5ac69fb5d3e64bf0 Mon Sep 17 00:00:00 2001 From: Chris Lalancette Date: Fri, 30 Jul 2010 09:39:48 -0400 Subject: [PATCH] Fix a memory leak in the qemudBuildCommandLine. ADD_ARG_LIT should only be used for literal arguments, since it duplicates the memory. Since virBufferContentAndReset is already allocating memory, we should only use ADD_ARG. Signed-off-by: Chris Lalancette --- src/qemu/qemu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 7c63bdcb30..a79e0d7d84 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -4110,7 +4110,7 @@ int qemudBuildCommandLine(virConnectPtr conn, goto error; } - ADD_ARG_LIT(virBufferContentAndReset(&boot_buf)); + ADD_ARG(virBufferContentAndReset(&boot_buf)); } if (def->os.kernel) { -- GitLab