From 425e5783f9ee466528db48558e293411479e3547 Mon Sep 17 00:00:00 2001 From: Michael Chapman Date: Tue, 17 Sep 2019 17:03:56 +1000 Subject: [PATCH] util: fix byte order of port in virSocketAddrResolveService MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The ports in the socket address structures returned by getaddrinfo() are in network byte order. Convert to host byte order before returning them. Reviewed-by: Daniel P. Berrangé Signed-off-by: Michael Chapman --- src/util/virsocketaddr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index c1fd5ec3d2..bba2089436 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -265,12 +265,12 @@ int virSocketAddrResolveService(const char *service) if (tmp->ai_family == AF_INET) { struct sockaddr_in in; memcpy(&in, tmp->ai_addr, sizeof(in)); - port = in.sin_port; + port = ntohs(in.sin_port); goto cleanup; } else if (tmp->ai_family == AF_INET6) { struct sockaddr_in6 in; memcpy(&in, tmp->ai_addr, sizeof(in)); - port = in.sin6_port; + port = ntohs(in.sin6_port); goto cleanup; } tmp++; -- GitLab