diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 3e3af41a96417b64f5abaacf24e1629a54d66752..3c9b26a974e36fabdaf54a652168670c783df832 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -987,7 +987,6 @@ struct virQEMUCapsStringFlags virQEMUCapsMigration[] = { }; struct virQEMUCapsStringFlags virQEMUCapsEvents[] = { - { "BALLOON_CHANGE", QEMU_CAPS_BALLOON_EVENT }, { "SPICE_MIGRATE_COMPLETED", QEMU_CAPS_SEAMLESS_MIGRATION }, { "DEVICE_DELETED", QEMU_CAPS_DEVICE_DEL_EVENT }, { "MIGRATION", QEMU_CAPS_MIGRATION_EVENT }, diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 928cf78e3d50d1343f825a1c072e6ddd5f14425a..d6aca729c0af1ebb42442099b9ef012ab1b1561e 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -183,7 +183,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */ QEMU_CAPS_DUMP_GUEST_MEMORY, /* dump-guest-memory command */ QEMU_CAPS_NEC_USB_XHCI, /* -device nec-usb-xhci */ QEMU_CAPS_VIRTIO_S390, /* -device virtio-*-s390 */ - QEMU_CAPS_BALLOON_EVENT, /* Async event for balloon changes */ + X_QEMU_CAPS_BALLOON_EVENT, /* Async event for balloon changes */ /* 100 */ X_QEMU_CAPS_NETDEV_BRIDGE, /* bridge helper support */ diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index fde0f9e19ecfd081a44c0a43144bc7c2c50de23e..1769419604600b7273a3ef7b30f9e5f975c2dde6 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10262,21 +10262,15 @@ qemuDomainMachineHasBuiltinIDE(const char *machine) /** * qemuDomainUpdateCurrentMemorySize: * - * Updates the current balloon size from the monitor if necessary. In case when - * the balloon is not present for the domain, the function recalculates the - * maximum size to reflect possible changes. + * In case when the balloon is not present for the domain, the function + * recalculates the maximum size to reflect possible changes. * - * Returns 0 on success and updates vm->def->mem.cur_balloon if necessary, -1 on - * error and reports libvirt error. + * Returns 0 on success and updates vm->def->mem.cur_balloon if necessary. */ int -qemuDomainUpdateCurrentMemorySize(virQEMUDriverPtr driver, +qemuDomainUpdateCurrentMemorySize(virQEMUDriverPtr driver ATTRIBUTE_UNUSED, virDomainObjPtr vm) { - qemuDomainObjPrivatePtr priv = vm->privateData; - unsigned long long balloon; - int ret = -1; - /* inactive domain doesn't need size update */ if (!virDomainObjIsActive(vm)) return 0; @@ -10288,35 +10282,6 @@ qemuDomainUpdateCurrentMemorySize(virQEMUDriverPtr driver, return 0; } - /* current size is always automagically updated via the event */ - if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BALLOON_EVENT)) - return 0; - - /* here we need to ask the monitor */ - - /* Don't delay if someone's using the monitor, just use existing most - * recent data instead */ - if (qemuDomainJobAllowed(priv, QEMU_JOB_QUERY)) { - if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) - return -1; - - if (virDomainObjCheckActive(vm) < 0) - goto endjob; - - qemuDomainObjEnterMonitor(driver, vm); - ret = qemuMonitorGetBalloonInfo(priv->mon, &balloon); - if (qemuDomainObjExitMonitor(driver, vm) < 0) - ret = -1; - - endjob: - qemuDomainObjEndJob(driver, vm); - - if (ret < 0) - return -1; - - vm->def->mem.cur_balloon = balloon; - } - return 0; } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7106f6d553e1cbb7fe1610fdee68e12019991c51..e1c1450488aae5e4b136dd83cb5689e5f21611a1 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20295,26 +20295,22 @@ qemuDomainGetStatsBalloon(virQEMUDriverPtr driver, int *maxparams, unsigned int privflags) { - qemuDomainObjPrivatePtr priv = dom->privateData; virDomainMemoryStatStruct stats[VIR_DOMAIN_MEMORY_STAT_NR]; int nr_stats; unsigned long long cur_balloon = 0; size_t i; - int err = 0; if (!virDomainDefHasMemballoon(dom->def)) { cur_balloon = virDomainDefGetMemoryTotal(dom->def); - } else if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BALLOON_EVENT)) { - cur_balloon = dom->def->mem.cur_balloon; } else { - err = -1; + cur_balloon = dom->def->mem.cur_balloon; } - if (!err && virTypedParamsAddULLong(&record->params, - &record->nparams, - maxparams, - "balloon.current", - cur_balloon) < 0) + if (virTypedParamsAddULLong(&record->params, + &record->nparams, + maxparams, + "balloon.current", + cur_balloon) < 0) return -1; if (virTypedParamsAddULLong(&record->params, diff --git a/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml index 6a0b1239930d88dc73ca9a7971b80d068d2fe68d..6c96e8b01327f59538e30cb5f28187bce63fe18c 100644 --- a/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml index 5a9159265303c3c43dcc29fdb2f83ba54cbf92e0..038173c9b939b7101997ab589353628cd3e95b02 100644 --- a/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml index 0507e02cc61032465887086376c4b86627e95347..f9ceeede389df59c434c9d21fa0255842482602c 100644 --- a/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml index 3c268f8d7aa2054eb4e7ec53fc32a6cf8de7633e..f2fa718c1cc27f163d08bfb79bcb859c408eb307 100644 --- a/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml index 30eafac64f6cefaecd8d8ad660c82a106469958f..e28b8e9313385d7f36adb112ec9046d03a4224c2 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml @@ -26,7 +26,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml index 1c8b5f42379b12d899ca9c8c0bc93501fcc9dde9..ea46831708b33eabc4b6492a164688cae3dc7b29 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml @@ -25,7 +25,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml index 7347eff579c9decd79bb54b5276450c505dfdf2b..9ea1885e4737c91ce535d21fc7ee624df96f597f 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml @@ -14,7 +14,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml index a5b9eecf17561dcf16513528679f0e8152623dc7..355f5bbf6b5433dfe3c7563cf4db5b38d99ebd74 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml index d26506bc620d471f9074e59a4b79c6ba0087be74..f5f4ee1393ba7f725559601c8ba626cb73c5dfa3 100644 --- a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml @@ -14,7 +14,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml index 38ef7207e8303da83f5ea1004325acba990e9db0..f42bec715cdb78b8957e3253a7ea6af9c7c4e294 100644 --- a/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml index 67f320cc71a9419e2ac9e76bb4f3313fba07010c..6d40702def42fe6aab160fb2f25e8f4d175a227f 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml @@ -26,7 +26,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml index e07c1fa6d60ca135154a8ee16cbc26037f5a64e9..f893ffeccd7e94356ab9ab206decbfa11733e1e0 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml @@ -25,7 +25,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml index 154fb4453203d1a047cd2222efd11d196a1c48de..2502c1331b55498584ee8d89ef20b38d1adb5f65 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml @@ -14,7 +14,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml index 94e8c877a2d79649508847f51163b86513bdca30..dd45ca22493abcb5c29658ac6ea10db1eb351c8e 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml index 5dff12e745eefe6588cc5a8110e5349319b0d96a..1a7f19b9b69e109e76d20e40f3dbcbd329f02fbf 100644 --- a/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml index e3e1ca3cad1762db9e6503934692bb063a9c60ac..338f9ea606f4d2b835633578d3be8ecad8f5f886 100644 --- a/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml index 0371991523e132bc9a0e2abcf7d97ba7e2676dcb..df0c0dbc57b0b0754c5485a6add8191990b5b55c 100644 --- a/tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml @@ -28,7 +28,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml index 9494a72e3e411cd9541ff5a015eb72828976dd85..d482c437ceedee9ac2ddbebe1c86a4b62ae5bf0b 100644 --- a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml @@ -25,7 +25,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml index 89bdcb116ca236c84d613a3c0dda8c7293094dc9..23f9a60c95728025ba75b0210516b90ecba91641 100644 --- a/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml index e50c83950f4ea1d1344e61c03bafc42130423f54..ccc4a738b4671bd34cea99416923a5bbd58dc654 100644 --- a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml @@ -14,7 +14,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml index cc555fb48a5cfb070f34e38b30c4a2a8bb15aa51..46bfab88d0f28649f109480cbecd4c89f2f3911a 100644 --- a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml index 6b975be02f779d9df537ef5c339e90992475eeb2..ea930b807d21db9be366031ff285b11c8e9aa48c 100644 --- a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml @@ -14,7 +14,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml index f2dbfe3cdec05485687f6f1e9fa73d0f50bae72b..a0c8d68ee5b8728b1fd04822e089564346e0b3d7 100644 --- a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml index cea056f313da8bbcf0ee742eca853190c43fe511..1ac331a252886df26aecbc4c5c3b4327d6268bd8 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml @@ -25,7 +25,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml index 7101f155ff8dfee9bf73f667001e3ac07d2d8658..c4f3387273cb6f2af69852f19dcc20a02e9f3c84 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml @@ -14,7 +14,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml index fe900edd921d77193b432b3517f9b6bdae5fe0cd..7ae0b81489cc9e0a66395eca043769dd32014673 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml index 226023a8b2f922a588a82377d7978b272b26a888..c70e8909cee430e33c25c979d26b6b45aaba0342 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml @@ -25,7 +25,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml b/tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml index 3c2028323fa86e97f44f10d52cb34bcae24d87a9..17802b59e5a3c4f613e5353fce89336f380331d6 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml @@ -8,7 +8,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml b/tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml index dc5a0fd42a8820458e2619d4195a141eff5cbb63..d06e2f8707e05a2616e069932c37dd76f15ed623 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml @@ -8,7 +8,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml b/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml index ecbdbdc716b9192b5cab4e5e9ed770e8b7b143e3..87e9378248a2675fc42fa24509af26d8dd4ef8b1 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml @@ -15,7 +15,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml index 01703f125c1f18c91be263f9e4f04c5e264b6f8c..7d77e657902b06fd407efbb2cd601163b7d946d4 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml index 29ff06581a2b4d445548a05e779ade296b9a8c62..97dbec12cf5923ea10f919b7312024bc8a8dceb0 100644 --- a/tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml @@ -25,7 +25,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml index c3bb278c5ab66afc1575597b69577e24b44e70ae..49dfc4f9b3ba3e5c5d2a2285e5603143e6b833c8 100644 --- a/tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml @@ -32,7 +32,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml b/tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml index 24741a0c9ec8204ab562a7808cec0b4fde50bcf9..19b7b197d2b883410dc237df2af500a19dca33e9 100644 --- a/tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml +++ b/tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml @@ -28,7 +28,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml b/tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml index 8a54767450f494725ac37b6b630a2e515fc9fcbb..3ce74f9839e030473f1558d354f63eca5c9dd00a 100644 --- a/tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml +++ b/tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml @@ -28,7 +28,6 @@ - diff --git a/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml index ab7c0dc7f9d1759091e8fbe5622ea754fe7ee8b2..3eb199d196be295759a253ea70f9802376ba7b2b 100644 --- a/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml @@ -32,7 +32,6 @@ -