diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 4ff6257f8409b54e7715f3920bba37b90f888ea7..9276d7d364c093b8f9560b9f4e9ae616a85f4c66 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -53,7 +53,7 @@ VIR_LOG_INIT("bhyve.bhyve_process"); -static virDomainObjPtr +static void bhyveProcessAutoDestroy(virDomainObjPtr vm, virConnectPtr conn ATTRIBUTE_UNUSED, void *opaque) @@ -62,12 +62,8 @@ bhyveProcessAutoDestroy(virDomainObjPtr vm, virBhyveProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_DESTROYED); - if (!vm->persistent) { + if (!vm->persistent) virDomainObjListRemove(driver->domains, vm); - vm = NULL; - } - - return vm; } static void diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 85c7bcc321dbb8c2750cb4ae26d1381401ed0b6f..96041f2ec7b0a870f42729b658a79e5ec3e612c3 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -59,7 +59,7 @@ VIR_LOG_INIT("lxc.lxc_process"); #define START_POSTFIX ": starting up\n" -static virDomainObjPtr +static void lxcProcessAutoDestroy(virDomainObjPtr dom, virConnectPtr conn, void *opaque) @@ -79,15 +79,11 @@ lxcProcessAutoDestroy(virDomainObjPtr dom, VIR_DOMAIN_EVENT_STOPPED_DESTROYED); priv->doneStopEvent = true; - if (!dom->persistent) { + if (!dom->persistent) virDomainObjListRemove(driver->domains, dom); - dom = NULL; - } if (event) virObjectEventStateQueue(driver->domainEventState, event); - - return dom; } /* diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index e5231555defc0cf8a259ce6d8b90e7967e5581df..256b994bd96e51ce0abcdbcbeecad75ce317ecdd 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1954,7 +1954,7 @@ qemuMigrationDstRun(virQEMUDriverPtr driver, * qemuDomainMigrateBegin3 and qemuDomainMigratePerform3 or * qemuDomainMigratePerform3 and qemuDomainMigrateConfirm3. */ -static virDomainObjPtr +static void qemuMigrationSrcCleanup(virDomainObjPtr vm, virConnectPtr conn, void *opaque) @@ -1969,7 +1969,7 @@ qemuMigrationSrcCleanup(virDomainObjPtr vm, priv->job.phase)); if (!qemuMigrationJobIsActive(vm, QEMU_ASYNC_JOB_MIGRATION_OUT)) - goto cleanup; + return; VIR_DEBUG("The connection which started outgoing migration of domain %s" " was closed; canceling the migration", @@ -2005,9 +2005,6 @@ qemuMigrationSrcCleanup(virDomainObjPtr vm, /* unreachable */ ; } - - cleanup: - return vm; } diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 0e7965fc0836dffb260f893c6ea2be2b6cd3212d..159618636603a8ec7d48f1e8e7fee95ae9ba21a8 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7046,7 +7046,7 @@ int qemuProcessAttach(virConnectPtr conn ATTRIBUTE_UNUSED, } -static virDomainObjPtr +static void qemuProcessAutoDestroy(virDomainObjPtr dom, virConnectPtr conn, void *opaque) @@ -7070,7 +7070,7 @@ qemuProcessAutoDestroy(virDomainObjPtr dom, VIR_DEBUG("Killing domain"); if (qemuProcessBeginStopJob(driver, dom, QEMU_JOB_DESTROY, true) < 0) - goto cleanup; + return; qemuProcessStop(driver, dom, VIR_DOMAIN_SHUTOFF_DESTROYED, QEMU_ASYNC_JOB_NONE, stopFlags); @@ -7085,9 +7085,6 @@ qemuProcessAutoDestroy(virDomainObjPtr dom, qemuDomainObjEndJob(driver, dom); qemuDomainEventQueue(driver, event); - - cleanup: - return dom; } int qemuProcessAutoDestroyAdd(virQEMUDriverPtr driver, diff --git a/src/util/virclosecallbacks.c b/src/util/virclosecallbacks.c index 4db50e8b678d8101b7e511f8f80f519154b14f39..49dac658926760f0e7ff46d1952c7e99c7604801 100644 --- a/src/util/virclosecallbacks.c +++ b/src/util/virclosecallbacks.c @@ -359,10 +359,9 @@ virCloseCallbacksRun(virCloseCallbacksPtr closeCallbacks, * we're about to call the callback function and we have another * ref anyway (so it cannot be deleted). * - * Call the callback function, ignoring the return since it might be - * NULL. Once we're done with the object, then end the API usage. */ + * Call the callback function and end the API usage. */ virObjectUnref(vm); - ignore_value(list->entries[i].callback(vm, conn, opaque)); + list->entries[i].callback(vm, conn, opaque); virDomainObjEndAPI(&vm); } VIR_FREE(list->entries); diff --git a/src/util/virclosecallbacks.h b/src/util/virclosecallbacks.h index d489971810509a1f1c0adfb2cff4894e3775935e..79ca635bd7538a4a030f919712b008f3fb10d628 100644 --- a/src/util/virclosecallbacks.h +++ b/src/util/virclosecallbacks.h @@ -30,9 +30,9 @@ typedef struct _virCloseCallbacks virCloseCallbacks; typedef virCloseCallbacks *virCloseCallbacksPtr; -typedef virDomainObjPtr (*virCloseCallback)(virDomainObjPtr vm, - virConnectPtr conn, - void *opaque); +typedef void (*virCloseCallback)(virDomainObjPtr vm, + virConnectPtr conn, + void *opaque); virCloseCallbacksPtr virCloseCallbacksNew(void); int virCloseCallbacksSet(virCloseCallbacksPtr closeCallbacks, virDomainObjPtr vm,