From 3d8a3d6e5b700c66ac67ab60d10c1366281a50fb Mon Sep 17 00:00:00 2001 From: Jim Fehlig Date: Thu, 6 Feb 2014 14:36:49 -0700 Subject: [PATCH] libxl: register for domain events immediately after creation A small fix for the possiblitiy of jumping to an error path before registering for domain events, preventing receiving important ones like shutdown and death. --- src/libxl/libxl_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 50fbe5cfb4..99643e3640 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -690,6 +690,9 @@ libxlVmStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm, } vm->def->id = domid; + if (libxlDomEventsRegister(vm) < 0) + goto error; + if ((dom_xml = virDomainDefFormat(vm->def, 0)) == NULL) goto error; @@ -700,9 +703,6 @@ libxlVmStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm, goto error; } - if (libxlDomEventsRegister(vm) < 0) - goto error; - if (libxlDomainSetVcpuAffinities(driver, vm) < 0) goto error; -- GitLab