From 3b3debfb7f70696e55642ed34be2848d8ba4b8b7 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 28 Apr 2016 16:45:02 +0200 Subject: [PATCH] qemu: domain: Check few more fields for when changing disk source Both disk->src->shared and disk->src->readonly can't be modified when changing disk source for floppy and cdrom drives since both arguments are passed as arguments of the disk rather than the image in qemu. Historically these fields have only two possible values since they are represented as XML thus we need to ignore if user did not provide them and thus we are treating them as false. --- src/qemu/qemu_domain.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 8132ff6930..f6e68ea918 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3940,6 +3940,12 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk, return false; } + /* checks for fields stored in disk->src */ + /* unfortunately 'readonly' and 'shared' can't be converted to tristate + * values thus we need to ignore the check if the new value is 'false' */ + CHECK_EQ(src->readonly, "readonly", true); + CHECK_EQ(src->shared, "shared", true); + #undef CHECK_EQ return true; -- GitLab