From 3b0bb65dd4c5e159956c44e99ae5dd24758e68be Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Fri, 9 Dec 2011 15:12:37 +0100 Subject: [PATCH] threadpool: Don't wait on condition if pool has no workers Pool creates new workers dynamically. However, it is possible for a pool to have no workers. If we want to free that pool, we don't want to wait on quit condition as it will never be signaled. --- src/util/threadpool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/threadpool.c b/src/util/threadpool.c index c16e2aff60..883d1e5bdd 100644 --- a/src/util/threadpool.c +++ b/src/util/threadpool.c @@ -258,7 +258,8 @@ void virThreadPoolFree(virThreadPoolPtr pool) virCondBroadcast(&pool->prioCond); } - ignore_value(virCondWait(&pool->quit_cond, &pool->mutex)); + if (pool->nWorkers > 0 || pool->nPrioWorkers > 0) + ignore_value(virCondWait(&pool->quit_cond, &pool->mutex)); while ((job = pool->jobList.head)) { pool->jobList.head = pool->jobList.head->next; -- GitLab