From 369199d1a99171ef3d28cdadb9f2f345c7424d53 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Fri, 15 Sep 2017 16:32:00 +0200 Subject: [PATCH] qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy Because qemuDomainDefCopy needs a string representation of a domain definition, there's no reason for calling the lower level qemuDomainDefFormatBuf API. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ddc76b1c93..cb371f1e80 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4536,14 +4536,12 @@ qemuDomainDefCopy(virQEMUDriverPtr driver, virDomainDefPtr src, unsigned int flags) { - virBuffer buf = VIR_BUFFER_INITIALIZER; virDomainDefPtr ret = NULL; - char *xml = NULL; + char *xml; - if (qemuDomainDefFormatBuf(driver, src, flags, &buf) < 0) + if (!(xml = qemuDomainDefFormatXML(driver, src, flags))) return NULL; - xml = virBufferContentAndReset(&buf); ret = qemuDomainDefFromXML(driver, xml); VIR_FREE(xml); -- GitLab