From 2cfc000f70d2ffd5db53cc725dba2f0472ce23d0 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Fri, 7 Sep 2018 16:01:26 -0400 Subject: [PATCH] qemu: Remove duplicated qemuAgentCheckError Commit 5b3492fadb moved qemuAgentCheckError calls into qemuAgentCommand for various reasons; however, subsequent commit b1aa91e14 restored the call. So let's just remove the duplicitous call from qemuAgentSetVCPUsCommand. Signed-off-by: John Ferlan ACKed-by: Michal Privoznik --- src/qemu/qemu_agent.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 0a1f3195dd..102ac36f0f 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1544,9 +1544,6 @@ qemuAgentSetVCPUsCommand(qemuAgentPtr mon, VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK) < 0) goto cleanup; - if (qemuAgentCheckError(cmd, reply) < 0) - goto cleanup; - /* All negative values are invalid. Return of 0 is bogus since we wouldn't * call the guest agent so that 0 cpus would be set successfully. Reporting * more successfully set vcpus that we've asked for is invalid. */ -- GitLab