From 2b8d0d44b92cfcc14476f366173783ea0dc854ae Mon Sep 17 00:00:00 2001 From: Nikolay Shirokovskiy Date: Thu, 12 Nov 2015 10:23:16 +0300 Subject: [PATCH] libvirt: Update virDomainSetMemory description virDomainSetMemory is documented to change only runtime configuration of running domain. However, that's not true of all hypervisors supported. Seems as though when commit id '0f2e50be5' added the current flag, the function description should have been updated similar to when commit id 'c1795c52' updated the virDomainSetMaxMemory description. Especially since commit id '80427f1d' updated the virsh 'setmem' description to indicate "behavior is different depending on hypervisor." This patch will update the description to match current functionality. Signed-off-by: Nikolay Shirokovskiy --- src/libvirt-domain.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 7cfc4d2ac3..b91388e77e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -1882,8 +1882,9 @@ virDomainSetMaxMemory(virDomainPtr domain, unsigned long memory) * to Domain0 i.e. the domain where the application runs. * This function may require privileged access to the hypervisor. * - * This command only changes the runtime configuration of the domain, - * so can only be called on an active domain. + * This command is hypervisor-specific for whether active, persistent, + * or both configurations are changed; for more control, use + * virDomainSetMemoryFlags(). * * Returns 0 in case of success and -1 in case of failure. */ -- GitLab