From 288c47406cffa7a6eb9e9c29764850b0cdeb5508 Mon Sep 17 00:00:00 2001 From: Erik Skultety Date: Thu, 18 Sep 2014 14:25:05 +0200 Subject: [PATCH] Fix libvirtd crash when removing metadata When trying to remove nonexistent metadata from XML, libvirt daemon crashes due to dereferencing NULL pointer. Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1143955 --- src/util/virxml.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/virxml.c b/src/util/virxml.c index a91da050a3..27ecf14a24 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -974,6 +974,9 @@ virXMLFindChildNodeByNs(xmlNodePtr root, { xmlNodePtr next; + if (!root) + return NULL; + for (next = root->children; next; next = next->next) { if (next->ns && STREQ_NULLABLE((const char *) next->ns->href, uri)) -- GitLab