From 2841a0ad0f028adab29bdb08797d6841e4a333d8 Mon Sep 17 00:00:00 2001
From: Laine Stump <laine@laine.org>
Date: Mon, 30 Jul 2012 00:47:44 -0400
Subject: [PATCH] conf: make error returns from virDomainActualNetDefFormat
 consistent

There was an error: label that simply did "return ret", but ret was
defaulted to -1, and was never used other than setting it manually to
0 just before a non-error return. Aside from this, some of the error
return paths used "goto error" and others used "return ret".

This patch removes ret and the error: label, and makes all error
returns just consistently do "return -1".
---
 src/conf/domain_conf.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ead8cf88c6..e3830803f1 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -11546,7 +11546,6 @@ virDomainActualNetDefFormat(virBufferPtr buf,
                             virDomainActualNetDefPtr def,
                             unsigned int flags)
 {
-    int ret = -1;
     const char *type;
     const char *mode;
 
@@ -11557,7 +11556,7 @@ virDomainActualNetDefFormat(virBufferPtr buf,
     if (!type) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("unexpected net type %d"), def->type);
-        return ret;
+        return -1;
     }
 
     virBufferAsprintf(buf, "      <actual type='%s'", type);
@@ -11584,7 +11583,7 @@ virDomainActualNetDefFormat(virBufferPtr buf,
             virReportError(VIR_ERR_INTERNAL_ERROR,
                            _("unexpected source mode %d"),
                            def->data.direct.mode);
-            return ret;
+            return -1;
         }
         virBufferAsprintf(buf, " mode='%s'/>\n", mode);
         break;
@@ -11603,21 +11602,18 @@ virDomainActualNetDefFormat(virBufferPtr buf,
     default:
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("unexpected net type %s"), type);
-        goto error;
+        return -1;
     }
 
     virBufferAdjustIndent(buf, 8);
     if (virNetDevVPortProfileFormat(def->virtPortProfile, buf) < 0)
        return -1;
     if (virNetDevBandwidthFormat(def->bandwidth, buf) < 0)
-        goto error;
+        return -1;
     virBufferAdjustIndent(buf, -8);
 
     virBufferAddLit(buf, "      </actual>\n");
-
-    ret = 0;
-error:
-    return ret;
+    return 0;
 }
 
 static int
-- 
GitLab