From 21fdb4fe707c8cccba8225fc82c189b9f5130153 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Fri, 20 May 2016 11:42:56 +0200 Subject: [PATCH] storage: do not clear vols before volume upload Commit 5e54361c added virStoragePoolObjClearVols before refreshPool to prevent duplicate volume entries. However it is not needed here because we're not refreshing the pool yet, just checking for the existence of the refresh callback. The actual refresh is done via virStorageVolFDStreamCloseCb in virStorageVolPoolRefreshThread, which already calls virStoragePoolObjClearVols. --- src/storage/storage_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index ce31e38c1e..eb5f688fac 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -2357,7 +2357,6 @@ storageVolUpload(virStorageVolPtr obj, * interaction and we can just lookup the backend in the callback * routine in order to call the refresh API. */ - virStoragePoolObjClearVols(pool); if (backend->refreshPool) { if (VIR_ALLOC(cbdata) < 0 || VIR_STRDUP(cbdata->pool_name, pool->def->name) < 0) -- GitLab