From 1e8446024a3ccb2458a17b5502c78c2dd00a2c4d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
Date: Fri, 18 Oct 2019 22:59:49 +0200
Subject: [PATCH] docs: hacking: remove notes about -Werror
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Our HACKING file is clear about requiring submission from a git
checkout, which automatically enables -Werror.

Remove the mentions of explicitly enabling it to alleviate
the collective cognitive encumbrance.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
---
 docs/hacking.html.in | 18 ++----------------
 1 file changed, 2 insertions(+), 16 deletions(-)

diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index c6ab15206a..cad0f1e8c1 100644
--- a/docs/hacking.html.in
+++ b/docs/hacking.html.in
@@ -141,14 +141,7 @@
       </li>
 
       <li><p>Run the automated tests on your code before submitting any changes.
-          In particular, configure with compile warnings set to
-          -Werror.  This is done automatically for a git checkout; from a
-          tarball, use:</p>
-<pre>
-  ./configure --enable-werror
-</pre>
-        <p>
-          and run the tests:
+          That is:
         </p>
 <pre>
   make check
@@ -1474,14 +1467,7 @@ int foo()
       how things work, it's better
       to wait for a more authoritative feedback though. Before committing, please
       also rebuild locally, run 'make check syntax-check', and make sure you
-      don't raise errors. Try to look for warnings too; for example,
-      configure with
-    </p>
-<pre>
-  --enable-compile-warnings=error
-</pre>
-    <p>
-      which adds -Werror to compile flags, so no warnings get missed
+      don't raise errors.
     </p>
 
     <p>
-- 
GitLab