diff --git a/docs/news.xml b/docs/news.xml index 22f00cc55c7628018231d80bd1bf712036402559..54337f782d57a65a7115c343a9e53c5382661dfa 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -145,6 +145,16 @@ libxl: fix dom0 autoballooning with Xen 4.8 + + + qemu: Allow empty script path to <interface/> + + + Historically, this was always allowed. Unfortunately, due to some + rework done for 1.3.2 release a bug was dragged in which suddenly + stop allowing domain with such configuration to start. + + diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index fa695d4a6e23adb6e604571c84db759bb0ccce7d..d123248787cf0cb1b11fed03b281b1147cf097eb 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -2615,6 +2615,10 @@ virNetDevRunEthernetScript(const char *ifname, const char *script) virCommandPtr cmd; int ret; + /* Not a bug! Previously we did accept script="" as a NO-OP. */ + if (STREQ(script, "")) + return 0; + cmd = virCommandNew(script); virCommandAddArgFormat(cmd, "%s", ifname); virCommandClearCaps(cmd);