diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c index 51a654a8504f3c890ca3f6fea35d030b5fbb9b8b..f2635865a439ac59bc785ce9c77568ed2c7a7fc2 100644 --- a/src/qemu/qemu_alias.c +++ b/src/qemu/qemu_alias.c @@ -451,17 +451,26 @@ qemuAssignDeviceAliases(virDomainDefPtr def, virQEMUCapsPtr qemuCaps) } +/* qemuAliasFromDisk + * @disk: Pointer to a disk definition + * + * Generate and return an alias for the device disk '-drive' + * + * Returns NULL with error or a string containing the alias + */ char * qemuAliasFromDisk(const virDomainDiskDef *disk) { char *ret; if (!disk->info.alias) { - virReportError(VIR_ERR_INVALID_ARG, "%s", _("disk does not have an alias")); + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("disk does not have an alias")); return NULL; } - ignore_value(virAsprintf(&ret, "drive-%s", disk->info.alias)); + ignore_value(virAsprintf(&ret, "%s%s", QEMU_DRIVE_HOST_PREFIX, + disk->info.alias)); return ret; } diff --git a/src/qemu/qemu_alias.h b/src/qemu/qemu_alias.h index d1c6ba82b8d87ca6c733e630a7713b7c781e1e52..5202f734c99d8d07081d9a6d0fb259f9068e2a62 100644 --- a/src/qemu/qemu_alias.h +++ b/src/qemu/qemu_alias.h @@ -30,6 +30,8 @@ # include "qemu_domain.h" # include "qemu_domain_address.h" +# define QEMU_DRIVE_HOST_PREFIX "drive-" + int qemuAssignDeviceChrAlias(virDomainDefPtr def, virDomainChrDefPtr chr, ssize_t idx); diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 526b54c00ad84d4b80285330c26540710d40e914..137eb735a0ba6acd0bcbf9f7209d2d3febe33be3 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -274,17 +274,6 @@ qemuVirCommandGetDevSet(virCommandPtr cmd, int fd) } -char *qemuDeviceDriveHostAlias(virDomainDiskDefPtr disk) -{ - char *ret; - - if (virAsprintf(&ret, "%s%s", - QEMU_DRIVE_HOST_PREFIX, disk->info.alias) < 0) - return NULL; - return ret; -} - - static int qemuBuildDeviceAddressStr(virBufferPtr buf, const virDomainDef *domainDef, diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index c4d056703682537b170d01ee46de65f311e09a00..dcf9ba63382a6adedfddcb1578f54cd0d9fa1216 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -37,7 +37,6 @@ /* Config type for XML import/export conversions */ # define QEMU_CONFIG_FORMAT_ARGV "qemu-argv" -# define QEMU_DRIVE_HOST_PREFIX "drive-" # define QEMU_FSDEV_HOST_PREFIX "fsdev-" # define QEMU_BLOCK_IOTUNE_MAX 1000000000000000LL diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index fd365def7abd9a3402750ca3fe0b3cf9084ac920..356741fd32777d2050fa2a447874c9f59e944b98 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -229,7 +229,7 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, if (qemuDomainPrepareDisk(driver, vm, disk, newsrc, false) < 0) goto cleanup; - if (!(driveAlias = qemuDeviceDriveHostAlias(disk))) + if (!(driveAlias = qemuAliasFromDisk(disk))) goto error; qemuDomainObjEnterMonitor(driver, vm); @@ -369,7 +369,7 @@ qemuDomainAttachVirtioDiskDevice(virConnectPtr conn, if (!(drivestr = qemuBuildDriveStr(disk, false, priv->qemuCaps))) goto error; - if (!(drivealias = qemuDeviceDriveHostAlias(disk))) + if (!(drivealias = qemuAliasFromDisk(disk))) goto error; if (!(devstr = qemuBuildDriveDevStr(vm->def, disk, 0, priv->qemuCaps))) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 463e6247331cb8e999b2f53931f4142875c3ae93..04c847e86df570ce1c72d483ab80931d491957db 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -36,7 +36,7 @@ #include "qemu_domain.h" #include "qemu_process.h" #include "qemu_capabilities.h" -#include "qemu_command.h" +#include "qemu_alias.h" #include "qemu_cgroup.h" #include "qemu_hotplug.h" #include "qemu_blockjob.h" diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index a415e593e4265c20c32d8ad5dc2767503cf037df..299526458b2a8a553b0059eb2dad11177c52e541 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -33,7 +33,7 @@ #include "qemu_monitor_text.h" #include "qemu_monitor_json.h" -#include "qemu_command.h" +#include "qemu_alias.h" #include "qemu_parse_command.h" #include "qemu_capabilities.h" #include "viralloc.h" diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index 00310d94a1351ac1cf9a4dec1695a3226287baa6..cf2979dab4c6d1f08153b0bececd710e85e4e424 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -31,7 +31,7 @@ #include #include "qemu_monitor_text.h" -#include "qemu_command.h" +#include "qemu_alias.h" #include "c-ctype.h" #include "c-strcasestr.h" #include "viralloc.h"