From 0c7cca36e7d5676ab2daf5f046177a4bac53080e Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Wed, 29 Aug 2012 15:30:34 +0200 Subject: [PATCH] qemu: Fix starting domains with no cpu cgroup If cgroups are enabled in general but cpu cgroup is disabled in qemu.conf or not mounted at all, libvirt would refuse to start any domain even though scheduler parameters are not set in domain XML. This patch makes cpu cgroup mandatory only for domains that actually want to use it. --- src/qemu/qemu_cgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index be1b96d714..df67ff306e 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -549,7 +549,8 @@ int qemuSetupCgroupForVcpu(struct qemud_driver *driver, virDomainObjPtr vm) if (driver->cgroup == NULL) return 0; /* Not supported, so claim success */ - if (!qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_CPU)) { + if ((period || quota) && + !qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_CPU)) { virReportError(VIR_ERR_SYSTEM_ERROR, "%s", _("cgroup cpu is not active")); return -1; -- GitLab