From 0ace4d985ad0a0475698f9335d688d567fea2576 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Fri, 14 Aug 2015 15:36:05 +0200 Subject: [PATCH] qemuDomainRename: Explicitly check if domain is renaming to itself It may happen that user (mistakenly) wants to rename a domain to itself. Which is no renaming at all. We should reject that with some meaningful error message. Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4c0532432a..083e4ff823 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19937,6 +19937,12 @@ static int qemuDomainRename(virDomainPtr dom, goto endjob; } + if (STREQ(vm->def->name, new_name)) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("Can't rename domain to itself")); + goto cleanup; + } + if (VIR_STRDUP(new_dom_name, new_name) < 0) goto endjob; -- GitLab