From 060c159b0874c9d5eec96fbaa4bdb6443c234fe2 Mon Sep 17 00:00:00 2001 From: Nitesh Konkar Date: Tue, 13 Dec 2016 21:31:39 +0530 Subject: [PATCH] perf: add stalled_cycles_frontend perf event support This patch adds support and documentation for the stalled_cycles_frontend perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 7 +++++++ docs/news.html.in | 6 +++--- docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-domain.h | 11 +++++++++++ src/libvirt-domain.c | 5 +++++ src/qemu/qemu_driver.c | 1 + src/util/virperf.c | 5 ++++- src/util/virperf.h | 3 +++ tests/genericxml2xmlindata/generic-perf.xml | 1 + tools/virsh.pod | 7 ++++++- 10 files changed, 42 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index cd3182bb6f..c6c2d2c7db 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1930,6 +1930,7 @@ <event name='branch_instructions' enabled='no'/> <event name='branch_misses' enabled='no'/> <event name='bus_cycles' enabled='no'/> + <event name='stalled_cycles_frontend' enabled='no'/> </perf> ... @@ -1990,6 +1991,12 @@ the count of bus cycles by applications running on the platform perf.bus_cycles + + stalled_cycles_frontend + the count of stalled cpu cycles in the frontend of the instruction + processor pipeline by applications running on the platform + perf.stalled_cycles_frontend +

Devices

diff --git a/docs/news.html.in b/docs/news.html.in index 09e4c9544a..52ac51d863 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -35,9 +35,9 @@
  • Improvements
    • perf: Add more perf statistics
      - Add support to get the count of branch instructions executed, - branch misses, and bus cycles by applications running on - the platform + Add support to get the count of branch instructions + executed, branch misses, bus cycles, and stalled frontend + cpu cycles by applications running on the platform
    • diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 21a7afa47f..9ce7cc9db2 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -430,6 +430,7 @@ branch_instructions branch_misses bus_cycles + stalled_cycles_frontend diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 6d74238bbd..8d608ddb3f 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2155,6 +2155,17 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats); */ # define VIR_PERF_PARAM_BUS_CYCLES "bus_cycles" +/** + * VIR_PERF_PARAM_STALLED_CYCLES_FRONTEND: + * + * Macro for typed parameter name that represents stalled_cycles_frontend + * perf event which can be used to measure the count of stalled cpu cycles + * in the frontend of the instruction processor pipeline by applications + * running on the platform. It corresponds to the + * "perf.stalled_cycles_frontend" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_STALLED_CYCLES_FRONTEND "stalled_cycles_frontend" + int virDomainGetPerfEvents(virDomainPtr dom, virTypedParameterPtr *params, int *nparams, diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 8218011267..c438921adf 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11236,6 +11236,11 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * long. It is produced by branch_misses perf event. * "perf.bus_cycles" - The count of bus cycles as unsigned long * long. It is produced by bus_cycles perf event. + * "perf.stalled_cycles_frontend" - The count of stalled cpu cycles in the + * frontend of the instruction processor + * pipeline as unsigned long long. It is + * produced by stalled_cycles_frontend + * perf event. * * Note that entire stats groups or individual stat fields may be missing from * the output in case they are not supported by the given hypervisor, are not diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ee99d6f805..45f8d56234 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9856,6 +9856,7 @@ qemuDomainSetPerfEvents(virDomainPtr dom, VIR_PERF_PARAM_BRANCH_INSTRUCTIONS, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_BRANCH_MISSES, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_BUS_CYCLES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_STALLED_CYCLES_FRONTEND, VIR_TYPED_PARAM_BOOLEAN, NULL) < 0) return -1; diff --git a/src/util/virperf.c b/src/util/virperf.c index 31a5585965..c21147a845 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -42,7 +42,7 @@ VIR_ENUM_IMPL(virPerfEvent, VIR_PERF_EVENT_LAST, "cpu_cycles", "instructions", "cache_references", "cache_misses", "branch_instructions", "branch_misses", - "bus_cycles"); + "bus_cycles", "stalled_cycles_frontend"); struct virPerfEvent { int type; @@ -96,6 +96,9 @@ static struct virPerfEventAttr attrs[] = { {.type = VIR_PERF_EVENT_BUS_CYCLES, .attrType = PERF_TYPE_HARDWARE, .attrConfig = PERF_COUNT_HW_BUS_CYCLES}, + {.type = VIR_PERF_EVENT_STALLED_CYCLES_FRONTEND, + .attrType = PERF_TYPE_HARDWARE, + .attrConfig = PERF_COUNT_HW_STALLED_CYCLES_FRONTEND}, }; typedef struct virPerfEventAttr *virPerfEventAttrPtr; diff --git a/src/util/virperf.h b/src/util/virperf.h index ac6d789518..a1ba399171 100644 --- a/src/util/virperf.h +++ b/src/util/virperf.h @@ -40,6 +40,9 @@ typedef enum { for applications */ VIR_PERF_EVENT_BRANCH_MISSES, /* Count of branch misses for applications */ VIR_PERF_EVENT_BUS_CYCLES, /* Count of bus cycles for applications*/ + VIR_PERF_EVENT_STALLED_CYCLES_FRONTEND, /* Count of stalled cpu cycles in + the frontend of the instruction + processor pipeline */ VIR_PERF_EVENT_LAST } virPerfEventType; diff --git a/tests/genericxml2xmlindata/generic-perf.xml b/tests/genericxml2xmlindata/generic-perf.xml index 56a6173796..db7684327c 100644 --- a/tests/genericxml2xmlindata/generic-perf.xml +++ b/tests/genericxml2xmlindata/generic-perf.xml @@ -23,6 +23,7 @@ + diff --git a/tools/virsh.pod b/tools/virsh.pod index 7b3cb74cb4..1a45b529dc 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -948,7 +948,8 @@ I<--perf> returns the statistics of all enabled perf events: "perf.cache_misses" - the count of caches misses, "perf.branch_instructions" - the count of branch instructions, "perf.branch_misses" - the count of branch misses, -"perf.bus_cycles" - the count of bus cycles +"perf.bus_cycles" - the count of bus cycles, +"perf.stalled_cycles_frontend" - the count of stalled frontend cpu cycles See the B command for more details about each event. @@ -2302,6 +2303,10 @@ B by applications running on the platform. bus_cycles - Provides the count of bus cycles executed by applications running on the platform. + stalled_cycles_frontend - Provides the count of stalled cpu + cycles in the frontend of the + instruction processor pipeline by + applications running on the platform. B: The statistics can be retrieved using the B command using the I<--perf> flag. -- GitLab