From 05c9a413364d5ab94117bbd3ae281ad0748d7fbb Mon Sep 17 00:00:00 2001 From: Matthias Bolte Date: Fri, 23 Jul 2010 18:09:46 +0200 Subject: [PATCH] virt-aa-helper: Ignore open errors again virt-aa-helper used to ignore errors when opening files. Commit a8853344994a7c6aaca882a5e949ab5536821ab5 refactored the related code and changed this behavior. virt-aa-helper didn't ignore open errors anymore and virt-aa-helper-test fails. Make sure that virt-aa-helper ignores open errors again. --- src/security/virt-aa-helper.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 521545dea5..c116d5876b 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -844,9 +844,13 @@ get_files(vahControl * ctl) } for (i = 0; i < ctl->def->ndisks; i++) { + /* XXX passing ignoreOpenFailure = true to get back to the behavior + * from before using virDomainDiskDefForeachPath. actually we should + * be passing ignoreOpenFailure = false and handle open errors more + * careful than just ignoring them */ int ret = virDomainDiskDefForeachPath(ctl->def->disks[i], ctl->allowDiskFormatProbing, - false, + true, add_file_path, &buf); if (ret != 0) -- GitLab