From 025e19981008662dc230562b5e9d8faa86027384 Mon Sep 17 00:00:00 2001 From: Hu Tao Date: Wed, 30 Mar 2011 10:34:16 +0800 Subject: [PATCH] qemu: unlock qemu driver before return from domain save qemuDriverUnlock() wasn't called on 2 exit paths * src/qemu/qemu_driver.c: fix qemudDomainSave() to always unlock the driver before exiting on error --- src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 8505669a15..dd12dc8550 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2068,13 +2068,13 @@ static int qemudDomainSave(virDomainPtr dom, const char *path) qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", _("Invalid save image format specified " "in configuration file")); - return -1; + goto cleanup; } if (!qemudCompressProgramAvailable(compressed)) { qemuReportError(VIR_ERR_OPERATION_FAILED, "%s", _("Compression program for image format " "in configuration file isn't available")); - return -1; + goto cleanup; } } -- GitLab