1. 21 6月, 2008 1 次提交
    • L
      [watchdog] hpwdt: fix use of inline assembly · 1f6ef234
      Linus Torvalds 提交于
      The inline assembly in drivers/watchdog/hpwdt.c was incredibly broken,
      and included all the function prologue and epilogue stuff, even though
      it was itself then inside a C function where the compiler would add its
      own prologue and epilogue on top of it all.
      
      This then just _happened_ to work if you had exactly the right compiler
      version and exactly the right compiler flags, so that gcc just happened
      to not create any prologue at all (the gcc-generated epilogue wouldn't
      matter, since it would never be reached).
      
      But the more proper way to fix it is to simply not do this.  Move the
      inline asm to the top level, with no surrounding function at all (the
      better alternative would be to remove the prologue and make it actually
      use proper description of the arguments to the inline asm, but that's a
      bigger change than the one I'm willing to make right now).
      Tested-by: NS.Çağlar Onur <caglar@pardus.org.tr>
      Acked-by: NThomas Mingarelli <Thomas.Mingarelli@hp.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      1f6ef234
  2. 20 6月, 2008 1 次提交
  3. 19 6月, 2008 19 次提交
  4. 18 6月, 2008 12 次提交
  5. 17 6月, 2008 7 次提交