1. 04 3月, 2009 5 次提交
    • R
      net pcmcia: worklimit reaches -1 · b9bdcd9b
      Roel Kluin 提交于
      with while (--worklimit >= 0); worklimit reaches -1 after the loop. In
      3c589_cs.c this caused a warning not to be printed.
      
      In 3c574_cs.c contrastingly, el3_rx() treats worklimit differently:
      
      static int el3_rx(struct net_device *dev, int worklimit)
      {
      	while (--worklimit >= 0) { ... }
      	return worklimit;
      }
      
      el3_rx() is only called by function el3_interrupt(): twice:
      
      static irqreturn_t el3_interrupt(int irq, void *dev_id)
      {
              int work_budget = max_interrupt_work;
      	while(...) {
      		if (...)
      			work_budget = el3_rx(dev, work_budget);
      		if (...)
      			work_budget = el3_rx(dev, work_budget);
      		if (--work_budget < 0) {
      		        ...
      		        break;
      		}
      	}
      }
      The error path can occur 2 too early.
      Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b9bdcd9b
    • R
      net: more timeouts that reach -1 · 858b9ced
      Roel Kluin 提交于
      with while (timeout-- > 0); timeout reaches -1 after the loop, so the tests
      below are off by one. also don't do an '< 0' test on an unsigned.
      Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      858b9ced
    • M
      net: fix tokenring license · 42224745
      Meelis Roos 提交于
      Currently, modular tokenring ("tr") lacks a license and fails to load:
      
      tr: module license 'unspecified' taints kernel.
      tr: Unknown symbol proc_net_fops_create
      
      Beacuse of this, no tokenring driver can load if it depends on modular 
      tr. Fix this by adding GPL module license as it is in the kernel.
      
      With this fix, tr module loads fine and tms380 driver also loads. Well, 
      it does'nt work but that's a different bug.
      Signed-off-by: NMeelis Roos <mroos@linux.ee>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      42224745
    • P
      dm9601: new vendor/product IDs · a1a69c8d
      Peter Korsgaard 提交于
      Add vendor/product IDs for new no name dm9601 compatible usb ethernet
      adaptors.
      Reported-by: NEric Lauriault <eric@linux.ca>
      Signed-off-by: NPeter Korsgaard <jacmet@sunsite.dk>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a1a69c8d
    • P
      netlink: invert error code in netlink_set_err() · 4843b93c
      Pablo Neira Ayuso 提交于
      The callers of netlink_set_err() currently pass a negative value
      as parameter for the error code. However, sk->sk_err wants a
      positive error value. Without this patch, skb_recv_datagram() called
      by netlink_recvmsg() may return a positive value to report an error.
      
      Another choice to fix this is to change callers to pass a positive
      error value, but this seems a bit inconsistent and error prone
      to me. Indeed, the callers of netlink_set_err() assumed that the
      (usual) negative value for error codes was fine before this patch :).
      
      This patch also includes some documentation in docbook format
      for netlink_set_err() to avoid this sort of confusion.
      Signed-off-by: NPablo Neira Ayuso <pablo@netfilter.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      4843b93c
  2. 03 3月, 2009 9 次提交
  3. 02 3月, 2009 5 次提交
  4. 01 3月, 2009 6 次提交
  5. 28 2月, 2009 15 次提交