From f589c6b50f48cee302ea75fdcdbb33af1ec5c16f Mon Sep 17 00:00:00 2001 From: Lipeng Sang Date: Wed, 8 Mar 2023 16:46:48 +0800 Subject: [PATCH] malidp: Fix NULL vs IS_ERR() checking stable inclusion from stable-v5.19.17 commit 15342f930ebebcfe36f2415049736a77d7d2e045 category: bugfix bugzilla: https://gitee.com/src-openeuler/kernel/issues/I6IXPT CVE: CVE-2023-23004 Reference: https://github.com/torvalds/linux/commit/15342f930ebebcfe36f2415049736a77d7d2e045 -------------------------------- commit 15342f930ebebcfe36f2415049736a77d7d2e045 upstream. The get_sg_table() function does not return NULL. It returns error pointers. Signed-off-by: Miaoqian Lin Signed-off-by: Liviu Dudau Link: https://lore.kernel.org/dri-devel/20211213072115.18098-1-linmq006@gmail.com/ Signed-off-by: Lipeng Sang --- drivers/gpu/drm/arm/malidp_planes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index f1e8bc39b16d..24604b410372 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c @@ -348,7 +348,7 @@ static bool malidp_check_pages_threshold(struct malidp_plane_state *ms, else sgt = obj->funcs->get_sg_table(obj); - if (!sgt) + if (IS_ERR(sgt)) return false; sgl = sgt->sgl; -- GitLab