提交 f2590e4b 编写于 作者: S Stephen Boyd 提交者: Bjorn Andersson

soc: qcom: rpmh-rsc: Fold WARN_ON() into if condition

Move the WARN_ON() into the if condition so the compiler can see that
the branch is unlikely() and possibly optimize it better.

Cc: Maulik Shah <mkshah@codeaurora.org>
Reviewed-by: NDouglas Anderson <dianders@chromium.org>
Reviewed-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NStephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20200521060425.24285-4-swboyd@chromium.orgSigned-off-by: NBjorn Andersson <bjorn.andersson@linaro.org>
上级 a0776620
...@@ -394,10 +394,8 @@ static irqreturn_t tcs_tx_done(int irq, void *p) ...@@ -394,10 +394,8 @@ static irqreturn_t tcs_tx_done(int irq, void *p)
for_each_set_bit(i, &irq_status, BITS_PER_TYPE(u32)) { for_each_set_bit(i, &irq_status, BITS_PER_TYPE(u32)) {
req = get_req_from_tcs(drv, i); req = get_req_from_tcs(drv, i);
if (!req) { if (WARN_ON(!req))
WARN_ON(1);
goto skip; goto skip;
}
err = 0; err = 0;
for (j = 0; j < req->num_cmds; j++) { for (j = 0; j < req->num_cmds; j++) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册